From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934037AbbFJRCH (ORCPT ); Wed, 10 Jun 2015 13:02:07 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:34794 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933690AbbFJRB4 (ORCPT ); Wed, 10 Jun 2015 13:01:56 -0400 Date: Wed, 10 Jun 2015 19:02:02 +0200 From: Johan Hovold To: Claudio Cappelli Cc: linux-usb@vger.kernel.org, Johan Hovold , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB SERIAL: option.c: add 2020:4000 IDs Message-ID: <20150610170202.GD1295@localhost> References: <4896608.KHgxjqNgqt@darkstar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4896608.KHgxjqNgqt@darkstar> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 10, 2015 at 06:08:09PM +0200, Claudio Cappelli wrote: > From: Claudio Cappelli > > Add device Olivetti Olicard 300 (Network Connect: MT6225) - IDs 2020:4000. > > Signed-off-by: Claudio Cappelli > Suggested-by: Lars Melin > > --- > > drivers/usb/serial/option.c | 1 + > 1 file changed, 1 insertion(+) > > > --- linux/drivers/usb/serial/option.c.orig 2015-06-10 10:42:43.000000000 +0200 > +++ linux/drivers/usb/serial/option.c 2015-06-10 10:53:06.825265579 +0200 > @@ -1765,6 +1765,7 @@ static const struct usb_device_id option > { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x00, 0x00) }, > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */ > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */ > + { USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) }, /* OLICARD300 - MT6225 */ > { USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) }, > { USB_DEVICE(VIATELECOM_VENDOR_ID, VIATELECOM_PRODUCT_CDS7) }, > { } /* Terminating entry */ You should run checkpatch.pl on your patch before submitting. It would have let you know that there are some white space issues (leading spaces). You can ignore the long-line-warning in this case. Thanks, Johan