Re: [PATCH 06/25] perf tools: Propagate thread maps through the evlist

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Wed, Jun 10, 2015 at 08:10:39PM +0200, Jiri Olsa escreveu:
> Propagate evlist's thread_map object through all the
> evsel objects.
> 
> It'll be handy to access evsel's threads directly
> in following patches.

Handy in what way? I.e. I should know one example without having to look
at future patches ;-)

- Arnaldo
 
> Link: http://lkml.kernel.org/n/tip-6vc92bytyy2d6c5entm5s698@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/util/evlist.c | 4 +++-
>  tools/perf/util/evsel.c  | 1 +
>  tools/perf/util/evsel.h  | 1 +
>  3 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 7cb579ca5629..f438881040f2 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -1100,7 +1100,9 @@ static int propagate_maps(struct perf_evlist *evlist, struct target *target)
>  		if (!evsel->cpus || target->cpu_list)
>  			evsel->cpus = cpu_map__get(evlist->cpus);
>  
> -		if (!evsel->cpus)
> +		evsel->threads = thread_map__get(evlist->threads);
> +
> +		if (!evsel->cpus || !evsel->threads)
>  			return -ENOMEM;
>  	}
>  
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 3bd5769dd7b9..bd1c3b71e455 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -903,6 +903,7 @@ void perf_evsel__exit(struct perf_evsel *evsel)
>  	perf_evsel__free_id(evsel);
>  	close_cgroup(evsel->cgrp);
>  	cpu_map__put(evsel->cpus);
> +	thread_map__put(evsel->threads);
>  	zfree(&evsel->group_name);
>  	zfree(&evsel->name);
>  	perf_evsel__object.fini(evsel);
> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> index 21ec08247d47..d18572223b08 100644
> --- a/tools/perf/util/evsel.h
> +++ b/tools/perf/util/evsel.h
> @@ -82,6 +82,7 @@ struct perf_evsel {
>  	struct cgroup_sel	*cgrp;
>  	void			*handler;
>  	struct cpu_map		*cpus;
> +	struct thread_map	*threads;
>  	unsigned int		sample_size;
>  	int			id_pos;
>  	int			is_pos;
> -- 
> 1.9.3