From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964870AbbFJUWL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Jun 2015 16:22:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58118 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933586AbbFJUWC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Jun 2015 16:22:02 -0400
Date: Wed, 10 Jun 2015 22:21:53 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 13/25] perf stat: Move
 perf_evsel__(alloc|free|reset)_stat_priv into evsel object
Message-ID: <20150610202153.GC6803@krava.redhat.com>
References: <1433959858-31858-1-git-send-email-jolsa@kernel.org>
 <1433959858-31858-14-git-send-email-jolsa@kernel.org>
 <20150610184925.GA3332@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150610184925.GA3332@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 10, 2015 at 03:49:25PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jun 10, 2015 at 08:10:46PM +0200, Jiri Olsa escreveu:
> > Moving perf_evsel__(alloc|free|reset)_stat_priv into evsel object,
> > so it could be used outside stat object in following patches.
>  
> > +++ b/tools/perf/util/evsel.c
>   
> > +void perf_evsel__reset_stat_priv(struct perf_evsel *evsel)
> > +{
> > +	int i;
> > +	struct perf_stat *ps = evsel->priv;
> > +
> > +	for (i = 0; i < 3; i++)
> > +		init_stats(&ps->res_stats[i]);
> > +
> > +	perf_stat_evsel_id_init(evsel);
> > +}
> 
> Please move this to some 'stat' specific place, so that evsel.c has
> nothing that is tool specific, like references to 'struct perf_stat'.

ok, util/stat.c then

jirka