From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933850AbbFJUXD (ORCPT ); Wed, 10 Jun 2015 16:23:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48384 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412AbbFJUWz (ORCPT ); Wed, 10 Jun 2015 16:22:55 -0400 Date: Wed, 10 Jun 2015 22:22:47 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Adrian Hunter , Andi Kleen , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Stephane Eranian Subject: Re: [PATCH 08/25] perf stat: Introduce perf_counts__(alloc|free|reset) functions Message-ID: <20150610202247.GD6803@krava.redhat.com> References: <1433959858-31858-1-git-send-email-jolsa@kernel.org> <1433959858-31858-9-git-send-email-jolsa@kernel.org> <20150610185427.GB3332@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150610185427.GB3332@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 10, 2015 at 03:54:27PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 10, 2015 at 08:10:41PM +0200, Jiri Olsa escreveu: > > Move 'struct perf_counts' allocation|free|reset code into > > separate functions. > > > > Link: http://lkml.kernel.org/n/tip-qu64zmm5zbpbkuybusnkg4gl@git.kernel.org > > Signed-off-by: Jiri Olsa > > --- > > tools/perf/builtin-stat.c | 19 +++++++------------ > > tools/perf/util/evsel.c | 28 +++++++++++++++++++++++----- > > tools/perf/util/evsel.h | 3 +++ > > 3 files changed, 33 insertions(+), 17 deletions(-) > > But please do not move it to 'evsel.[ch]', i.e. you're introducing a new > class, i.e. "perf_counts", you might as well put them in a separate > file, i.e. tools/perf/util/counts.[ch]. > > And please rename perf_counts__alloc() to perf_counds__new(), ditto for > __free() -> __delete(), ok jirka