From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754277AbbFKAsY (ORCPT ); Wed, 10 Jun 2015 20:48:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60096 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428AbbFKAsS (ORCPT ); Wed, 10 Jun 2015 20:48:18 -0400 Date: Wed, 10 Jun 2015 17:48:17 -0700 From: Greg Kroah-Hartman To: Tolga Ceylan Cc: Oleg Drokin , Andreas Dilger , Julia Lawall , Greg Donald , aybuke ozdemir , Al Viro , Tina Johnson , Joe Perches , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] staging: lustre/lustre/llite: get rid of incorrect type warning Message-ID: <20150611004817.GA26022@kroah.com> References: <1433804517-7709-1-git-send-email-tolga.ceylan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433804517-7709-1-git-send-email-tolga.ceylan@gmail.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2015 at 04:01:57PM -0700, Tolga Ceylan wrote: > In dir.c and llite_lib.c, sparse reports multiple warnings messages > due to different address spaces. This patch resolves these warnings > by adding the tag __user for username addresses. > > Signed-off-by: Tolga Ceylan Are you sure all of these are correct? The kernel/user api for lustre is a complex beast, and just casting away the pointer types isn't usually the proper thing to do in order to resolve the issues here. thanks, greg k-h