From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754272AbbFKKox (ORCPT ); Thu, 11 Jun 2015 06:44:53 -0400 Received: from mail-am1on0102.outbound.protection.outlook.com ([157.56.112.102]:45514 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752729AbbFKKop convert rfc822-to-8bit (ORCPT ); Thu, 11 Jun 2015 06:44:45 -0400 From: "Harisangam, Sharvari (S.)" To: Greg Kroah-Hartman , Lorenzo Stoakes , Cristina Opriceana , "Greg Donald" , Karthik Nayak , "Vaishali Thakkar" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Removed unnecessary bool comparisons in r8192U_dm.c Thread-Topic: [PATCH] Removed unnecessary bool comparisons in r8192U_dm.c Thread-Index: AQHQpCdZ5tV8WyeO0E6vupxYGcvRjJ2nHuOA Date: Thu, 11 Jun 2015 10:44:42 +0000 Message-ID: <20150611104431.GA45115@ubuntu> References: <20150611091621.GA44785@ubuntu> In-Reply-To: <20150611091621.GA44785@ubuntu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.0.77.198] x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1349; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:DB5PR06MB1349;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1349; x-forefront-prvs: 0604AFA86B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(51704005)(24454002)(164054003)(106116001)(2900100001)(77156002)(46102003)(5001770100001)(92566002)(76176999)(50986999)(2950100001)(33656002)(19580405001)(54356999)(2656002)(189998001)(66066001)(122556002)(40100003)(19580395003)(5002640100001)(87936001)(62966003)(33716001)(102836002)(86362001)(5001960100002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR06MB1349;H:DB5PR06MB1352.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-ID: <267FC42E47E7DC459D2EDF484022A9F0@eurprd06.prod.outlook.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2015 10:44:42.2512 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR06MB1349 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 11, 2015 at 02:46:21PM +0530, Harisangam Sharvari wrote: > From: Harisangam Sharvari > > This patch was detected with the help of coccinelle tool. > The unnecessary comparisons of bool variables are removed. > > Signed-off-by: Harisangam Sharvari > --- > drivers/staging/rtl8192u/r8192U_dm.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c > index 12dd19e..cf3537a 100644 > --- a/drivers/staging/rtl8192u/r8192U_dm.c > +++ b/drivers/staging/rtl8192u/r8192U_dm.c > @@ -563,7 +563,7 @@ static void dm_TXPowerTrackingCallback_TSSI(struct net_device *dev) > break; > } > } > - if (viviflag == true) { > + if (viviflag) { > write_nic_byte(dev, 0x1ba, 0); > viviflag = false; > RT_TRACE(COMP_POWER_TRACKING, "we filtered the data\n"); > @@ -766,7 +766,7 @@ void dm_txpower_trackingcallback(struct work_struct *work) > struct r8192_priv *priv = container_of(dwork, struct r8192_priv, txpower_tracking_wq); > struct net_device *dev = priv->ieee80211->dev; > > - if (priv->bDcut == true) > + if (priv->bDcut) > dm_TXPowerTrackingCallback_TSSI(dev); > else > dm_TXPowerTrackingCallback_ThermalMeter(dev); > @@ -1301,7 +1301,7 @@ void dm_initialize_txpower_tracking(struct net_device *dev) > { > struct r8192_priv *priv = ieee80211_priv(dev); > > - if (priv->bDcut == true) > + if (priv->bDcut) > dm_InitializeTXPowerTracking_TSSI(dev); > else > dm_InitializeTXPowerTracking_ThermalMeter(dev); > @@ -1357,7 +1357,7 @@ static void dm_check_txpower_tracking(struct net_device *dev) > #ifdef RTL8190P > dm_CheckTXPowerTracking_TSSI(dev); > #else > - if (priv->bDcut == true) > + if (priv->bDcut) > dm_CheckTXPowerTracking_TSSI(dev); > else > dm_CheckTXPowerTracking_ThermalMeter(dev); > @@ -1467,7 +1467,7 @@ void dm_cck_txpower_adjust(struct net_device *dev, bool binch14) > { /* dm_CCKTxPowerAdjust */ > struct r8192_priv *priv = ieee80211_priv(dev); > > - if (priv->bDcut == true) > + if (priv->bDcut) > dm_CCKTxPowerAdjust_TSSI(dev, binch14); > else > dm_CCKTxPowerAdjust_ThermalMeter(dev, binch14); > @@ -3062,7 +3062,7 @@ static void dm_dynamic_txpower(struct net_device *dev) > priv->bDynamicTxLowPower = false; > } else { > /* high power state check */ > - if (priv->undecorated_smoothed_pwdb < txlowpower_threshold && priv->bDynamicTxHighPower == true) > + if (priv->undecorated_smoothed_pwdb < txlowpower_threshold && priv->bDynamicTxHighPower) > priv->bDynamicTxHighPower = false; > > /* low power state check */ > -- > 1.7.9.5 I found that there are some errors in patch submission. Please discard this patch. I will send the new patch. Thanks, Harisangam Sharvari