From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH] perf tools: Display 0x for hex values when printing the attribute
Date: Thu, 11 Jun 2015 10:56:15 -0300 [thread overview]
Message-ID: <20150611135615.GC18048@kernel.org> (raw)
In-Reply-To: <1434027064-7554-1-git-send-email-adrian.hunter@intel.com>
Em Thu, Jun 11, 2015 at 03:51:04PM +0300, Adrian Hunter escreveu:
> Need to display '0x' prefix for hex values otherwise
> it is not obvious they are hex.
Thanks, applied.
- Arnaldo
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/util/evsel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index a3e36fc634dc..d4f9994ae47f 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -1058,7 +1058,7 @@ static void __p_read_format(char *buf, size_t size, u64 value)
>
> #define BUF_SIZE 1024
>
> -#define p_hex(val) snprintf(buf, BUF_SIZE, "%"PRIx64, (uint64_t)(val))
> +#define p_hex(val) snprintf(buf, BUF_SIZE, "%#"PRIx64, (uint64_t)(val))
> #define p_unsigned(val) snprintf(buf, BUF_SIZE, "%"PRIu64, (uint64_t)(val))
> #define p_signed(val) snprintf(buf, BUF_SIZE, "%"PRId64, (int64_t)(val))
> #define p_sample_type(val) __p_sample_type(buf, BUF_SIZE, val)
> --
> 1.9.1
next prev parent reply other threads:[~2015-06-11 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 12:51 [PATCH] perf tools: Display 0x for hex values when printing the attribute Adrian Hunter
2015-06-11 13:56 ` Arnaldo Carvalho de Melo [this message]
2015-06-12 8:51 ` [tip:perf/core] perf evsel: " tip-bot for Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611135615.GC18048@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox