public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
	Stephane Eranian <eranian@google.com>,
	mathieu.poirier@linaro.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context switches
Date: Thu, 11 Jun 2015 16:15:48 +0200	[thread overview]
Message-ID: <20150611141548.GW19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1433859670-10806-1-git-send-email-adrian.hunter@intel.com>

On Tue, Jun 09, 2015 at 05:21:10PM +0300, Adrian Hunter wrote:
> Tracepoints are no good at all for non-privileged users
> because they need either CAP_SYS_ADMIN or
> /proc/sys/kernel/perf_event_paranoid <= -1.
> 
> On the other hand, kernel software events need either
> CAP_SYS_ADMIN or /proc/sys/kernel/perf_event_paranoid <= 1.

So while I think it makes sense to allow some tracepoint outside of that
priv level, IOW have a per tracepoint priv level filter thingy, I don't
think sched_switch() is one of those because it explicitly exposes
timing information on other tasks.

> This new PERF_RECORD_SWITCH event does not have those problems
> and it also has a couple of other small advantages. It is
> easier to use because it is an auxiliary event (like mmap,
> comm and task events) which can be enabled by setting a single
> bit. It is smaller than sched:sched_switch and easier to parse.

Right, so the one wee problem I have is that this only provides sched_in
data, I imagine people might be interested in sched_out as well.

Typically the switch even provides prev and next and thereby is
complete, but since we're limiting it to the one specific task, we'll
not have the sched_out data.

> @@ -812,6 +813,18 @@ enum perf_event_type {
>  	 */
>  	PERF_RECORD_ITRACE_START		= 12,
>  
> +	/*
> +	 *
> +	 *
> +	 * struct {
> +	 *	struct perf_event_header	header;
> +	 *	u32				pid, tid;
> +	 *	u64				time;

all 3 are already part of sample_id.

> +	 * 	struct sample_id		sample_id;
> +	 * };
> + 	 */
> +	PERF_RECORD_SWITCH			= 13,

  reply	other threads:[~2015-06-11 14:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 14:21 [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context switches Adrian Hunter
2015-06-11 14:15 ` Peter Zijlstra [this message]
2015-06-11 16:34   ` Andi Kleen
2015-06-11 16:54     ` Peter Zijlstra
2015-06-12  0:47   ` David Ahern
2015-06-12 10:34     ` Adrian Hunter
2015-06-12 14:21       ` David Ahern
2015-06-12 16:13         ` Adrian Hunter
2015-06-12 11:12   ` Adrian Hunter
2015-06-12 12:09     ` Peter Zijlstra
2015-06-12 12:36       ` Arnaldo Carvalho de Melo
2015-06-12 13:15         ` Adrian Hunter
2015-06-12 13:28           ` Pawel Moll
2015-06-12 13:52             ` Pawel Moll
2015-06-12 14:30             ` David Ahern
2015-06-12 14:29     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150611141548.GW19282@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@kernel.org \
    --cc=pawel.moll@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox