From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Abdul, Hussain (H.)" <habdul@visteon.com>
Cc: "vthakkar1994@gmail.com" <vthakkar1994@gmail.com>,
"hamohammed.sa@gmail.com" <hamohammed.sa@gmail.com>,
"tapaswenipathak@gmail.com" <tapaswenipathak@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag
Date: Thu, 11 Jun 2015 07:36:40 -0700 [thread overview]
Message-ID: <20150611143640.GA24637@kroah.com> (raw)
In-Reply-To: <1434017608-20304-1-git-send-email-habdul@visteon.com>
On Thu, Jun 11, 2015 at 10:14:49AM +0000, Abdul, Hussain (H.) wrote:
> This patch add IRQF_ONESHOT flag in threaded IRQs request without a primary handler.
>
> Signed-off-by: Abdul Hussain <habdul@visteon.com>
> ---
> drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> index 0f524bb..7caaae0 100644
> --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> @@ -987,7 +987,7 @@ static int synaptics_rmi4_probe
> rmi4_data->number_of_interrupt_register);
> retval = request_threaded_irq(client->irq, NULL,
> synaptics_rmi4_irq,
> - platformdata->irq_type,
> + platformdata->irq_type | IRQF_ONESHOT,
> DRIVER_NAME, rmi4_data);
> if (retval) {
> dev_err(&client->dev, "Unable to get attn irq %d\n",
Have you tested this? This changes the behavior of the code, right?
next prev parent reply other threads:[~2015-06-11 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 10:14 [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag Abdul, Hussain (H.)
2015-06-11 14:36 ` gregkh [this message]
2015-06-12 6:47 ` Abdul, Hussain (H.)
2015-06-12 15:36 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611143640.GA24637@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=habdul@visteon.com \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tapaswenipathak@gmail.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox