From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754740AbbFKO5N (ORCPT ); Thu, 11 Jun 2015 10:57:13 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:36480 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbbFKO5H (ORCPT ); Thu, 11 Jun 2015 10:57:07 -0400 Date: Thu, 11 Jun 2015 20:26:54 +0530 From: Viresh Kumar To: Daniel Lezcano Cc: Thomas Gleixner , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard Subject: Re: [PATCH 2/6] clocksource: arm_global_timer: Migrate to new 'set-state' interface Message-ID: <20150611145654.GB4386@linux> References: <54f346e663f605e2f078a3114de85ba281d1e6d0.1433768426.git.viresh.kumar@linaro.org> <5579A011.8030900@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5579A011.8030900@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-06-15, 16:49, Daniel Lezcano wrote: > Acked-by: Daniel Lezcano Thanks :) > >- clk->set_mode = gt_clockevent_set_mode; > >+ clk->set_state_shutdown = gt_clockevent_shutdown; > >+ clk->set_state_periodic = gt_clockevent_set_periodic; > >+ clk->set_state_oneshot = gt_clockevent_shutdown; > > nit: it sounds weird to use the same function as the purpose of the > patch is use the new API which is to ventilate those functions > (anyway ...) Hmm, but there is no point creating two routines to do exactly the same thing. And this is making it evident that we actually shutdown the device in oneshot-state request. And enable it only when the next event is programmed. -- viresh