public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] drm/amdgpu: off by one check in dce_v8_0_hpd_irq()
@ 2015-06-11 15:13 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-06-11 15:13 UTC (permalink / raw)
  To: David Airlie
  Cc: Alex Deucher, Jammy Zhou, Christian König, yanyang1,
	Chunming Zhou, Marek Olšák, dri-devel, linux-kernel,
	kernel-janitors

It should be >= instead of > or we go beyond the end of the
interrupt_status_offsets[] array.  Also I changed it to use
ARRAY_SIZE().

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
index 9e8b9f1..0f70dc9 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
@@ -3397,7 +3397,7 @@ static int dce_v8_0_hpd_irq(struct amdgpu_device *adev,
 	uint32_t disp_int, mask, int_control, tmp;
 	unsigned hpd;
 
-	if (entry->src_data > 6) {
+	if (entry->src_data >= ARRAY_SIZE(interrupt_status_offsets)) {
 		DRM_DEBUG("Unhandled interrupt: %d %d\n", entry->src_id, entry->src_data);
 		return 0;
 	}

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-06-11 15:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-11 15:13 [patch] drm/amdgpu: off by one check in dce_v8_0_hpd_irq() Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox