From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753408AbbFKQZI (ORCPT ); Thu, 11 Jun 2015 12:25:08 -0400 Received: from down.free-electrons.com ([37.187.137.238]:57315 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751224AbbFKQZE (ORCPT ); Thu, 11 Jun 2015 12:25:04 -0400 Date: Thu, 11 Jun 2015 18:23:43 +0200 From: Maxime Ripard To: Krzysztof Kozlowski Cc: Vinod Koul , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, gabriel@unseen.is, Marek Szyprowski , Laurent Pinchart , stable@vger.kernel.org Subject: Re: [RFT PATCH] dmaengine: Fix choppy sound because of unimplemented resume Message-ID: <20150611162343.GK19653@lukather> References: <1433924227-28499-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZrCu0B0FMx3UnjE2" Content-Disposition: inline In-Reply-To: <1433924227-28499-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZrCu0B0FMx3UnjE2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 10, 2015 at 05:17:07PM +0900, Krzysztof Kozlowski wrote: > Some drivers implement only pause operation (no resuming). Example is > pl330 where pause is needed for getting residuum. pl330 does not support > resume operation, transfer must be stopped after pause. >=20 > However for slaves this is exposed always as "pause and resume" which > introduces subtle errors on Odroid U3 board (Exynos4412 with pl330). > After adding pause function to pl330 driver the audio playback > (utilizing DMA) gets choppy after some time (approximately 24 hours). >=20 > Fix this by exposing "cmd_pause" if and only if pause and resume are > implemented. >=20 > Signed-off-by: Krzysztof Kozlowski > Reported-by: gabriel@unseen.is > Reported-by: Marek Szyprowski > Cc: > Fixes: 88987d2c7534 ("dmaengine: pl330: add DMA_PAUSE feature") That looks reasonable. Acked-by: Maxime Ripard Thanks! (and sorry for that) Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --ZrCu0B0FMx3UnjE2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVebYPAAoJEBx+YmzsjxAgt3MP/2lwzD+nBPqcld9A7QtM1xTa Uvc9ekonzk6I8jCikyWEqEoTCidJdgghTc8zf1YgRL2uE9ikTFI1YDdIZ4DSZilm 5PZpEFuA6jJqICCat7BqxWHvgos32CS68YBvIMaq0/G2LfeUvT5WM674whBJj722 HU/1jdikyL1lSsAFX1k4WkB1SVmkEmTt8GWmGDVV28Wc5tub1DbYgpPFqJzmZD6q P4vRBiqdrgcP8JO1W717JwU1QgmjddjcQmYQOuSZjZdRwTEF4GKD53MYGme1eRke I3yBWEP80K2m5meSvFvmd/ppJZg8zBvwHSfTqHUDlHG2YoIPsDRsSpsMhjZEXRp4 BjCmzBVDjOyyD0lYiE9Lga9mReqJSa666kCKa+/TqHG3JlGyiiwg8H9oHzAXqqEv fgnwukQc4gehpzaLD3PwS3OSW/bPGx3hMB041j26s99MvF0O7nNCSjsai39I367T TIi9axY3A9+LTWVaOjTiOeN75WeAmigcml3NumUpKKb5WtcWaZMtLbH3qhPlNf63 vUcc5vlkrN4rTJNzSSU6uoNiSnzXKQdJvHImOySx9vB19KEIvrQIBKGosa4zvqZ+ pMaqnIDlG5ubeb4NGY/MW0E1OCliFxFP+C25/EOESPirJ0JSf1lLeJFAz1KXpNPE mJwkleV9o5zUOYBZ0+qC =uoGA -----END PGP SIGNATURE----- --ZrCu0B0FMx3UnjE2--