From: Ingo Molnar <mingo@kernel.org>
To: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Matt Fleming <matt.fleming@intel.com>,
fu.wei@linaro.org, al.stone@linaro.org, bp@alien8.de,
tony.luck@gmail.com, ying.huang@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/4] x86: acpi: define uncached page flag
Date: Fri, 12 Jun 2015 09:52:44 +0200 [thread overview]
Message-ID: <20150612075244.GB8759@gmail.com> (raw)
In-Reply-To: <1434047160-23358-2-git-send-email-zjzhang@codeaurora.org>
* Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org> wrote:
> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
>
> This definition is used in APEI code when needing to map pages as
> uncached.
>
> Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org>
> ---
> arch/x86/include/asm/acpi.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/x86/include/asm/acpi.h b/arch/x86/include/asm/acpi.h
> index 3a45668f6dc3..6afb27682b00 100644
> --- a/arch/x86/include/asm/acpi.h
> +++ b/arch/x86/include/asm/acpi.h
> @@ -138,6 +138,10 @@ static inline void disable_acpi(void) { }
>
> #endif /* !CONFIG_ACPI */
>
> +#ifdef CONFIG_ACPI_APEI
> +#define ARCH_APEI_PAGE_KERNEL_UC (PAGE_KERNEL_NOCACHE)
> +#endif /*CONFIG_ACPI_APEI */
- Why the tab?
- Why the parentheses?
- Why the closing comment block for a oneliner define? It's not like we forget
what it's about.
- When the missing space in the closing comment?
That's 4 uglies in 3 lines of code, wow ...
Thanks,
Ingo
next prev parent reply other threads:[~2015-06-12 7:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 18:25 [PATCH V3 0/4] map GHES memory region with EFI memory map Jonathan (Zhixiong) Zhang
2015-06-11 18:25 ` [PATCH V3 1/4] x86: acpi: define uncached page flag Jonathan (Zhixiong) Zhang
2015-06-12 7:52 ` Ingo Molnar [this message]
2015-06-12 23:49 ` Zhang, Jonathan Zhixiong
2015-06-11 18:25 ` [PATCH V3 2/4] arm64: " Jonathan (Zhixiong) Zhang
2015-06-11 18:25 ` [PATCH V3 3/4] efi: x86: rearrange efi_mem_attributes() Jonathan (Zhixiong) Zhang
2015-06-11 18:26 ` [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory Jonathan (Zhixiong) Zhang
2015-06-12 16:29 ` Borislav Petkov
2015-06-12 23:44 ` Zhang, Jonathan Zhixiong
2015-06-13 8:27 ` Borislav Petkov
2015-06-15 14:15 ` Matt Fleming
2015-06-15 14:59 ` Borislav Petkov
2015-06-22 5:11 ` Matt Fleming
2015-06-23 9:50 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612075244.GB8759@gmail.com \
--to=mingo@kernel.org \
--cc=al.stone@linaro.org \
--cc=bp@alien8.de \
--cc=fu.wei@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@gmail.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox