From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755328AbbFLKEL (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Jun 2015 06:04:11 -0400
Received: from mga11.intel.com ([192.55.52.93]:38376 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753360AbbFLKEH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Jun 2015 06:04:07 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,601,1427785200"; 
   d="scan'208";a="725931851"
Date: Fri, 12 Jun 2015 15:35:33 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org, gabriel@unseen.is,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        stable@vger.kernel.org
Subject: Re: [RFT PATCH] dmaengine: Fix choppy sound because of unimplemented
 resume
Message-ID: <20150612100533.GG28601@localhost>
References: <1433924227-28499-1-git-send-email-k.kozlowski@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433924227-28499-1-git-send-email-k.kozlowski@samsung.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 10, 2015 at 05:17:07PM +0900, Krzysztof Kozlowski wrote:
> Some drivers implement only pause operation (no resuming). Example is
> pl330 where pause is needed for getting residuum. pl330 does not support
> resume operation, transfer must be stopped after pause.
> 
> However for slaves this is exposed always as "pause and resume" which
> introduces subtle errors on Odroid U3 board (Exynos4412 with pl330).
> After adding pause function to pl330 driver the audio playback
> (utilizing DMA) gets choppy after some time (approximately 24 hours).
> 
> Fix this by exposing "cmd_pause" if and only if pause and resume are
> implemented.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reported-by: gabriel@unseen.is
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: <stable@vger.kernel.org>
> Fixes: 88987d2c7534 ("dmaengine: pl330: add DMA_PAUSE feature")

Applied, thanks
-- 
~Vinod