From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Zidan Wang <zidan.wang@freescale.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.de, lars@metafoo.de,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel][PATCH 3/4] ASoC: wm8960: add kcontrol to select ADC data output
Date: Fri, 12 Jun 2015 13:29:18 +0100 [thread overview]
Message-ID: <20150612122918.GG32730@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <e7e1d4817ea6d4a1140a31ed21c5860cbaaaad3c.1434020423.git.zidan.wang@freescale.com>
On Thu, Jun 11, 2015 at 07:14:35PM +0800, Zidan Wang wrote:
> add kcontrol to select ADC data output.
>
> Signed-off-by: Zidan Wang <zidan.wang@freescale.com>
> ---
> sound/soc/codecs/wm8960.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
> index c1be15c..62246f1 100644
> --- a/sound/soc/codecs/wm8960.c
> +++ b/sound/soc/codecs/wm8960.c
> @@ -141,6 +141,12 @@ static const char *wm8960_3d_upper_cutoff[] = {"High", "Low"};
> static const char *wm8960_3d_lower_cutoff[] = {"Low", "High"};
> static const char *wm8960_alcfunc[] = {"Off", "Right", "Left", "Stereo"};
> static const char *wm8960_alcmode[] = {"ALC", "Limiter"};
> +static const char *wm8960_adc_data_sel[] = {
> + "ldata = left ADC; rdata = right ADC",
> + "ldata = left ADC; rdata = left ADC",
> + "ldata = right ADC; rdata = right ADC",
> + "ldata = right ADC; rdata = left ADC",
> +};
I see the datasheet lists this as one field but it would probably
look nicer as two controls, one to select the left channel source
and one for the right channel source.
Thanks,
Charles
next prev parent reply other threads:[~2015-06-12 12:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1434020423.git.zidan.wang@freescale.com>
2015-06-11 11:14 ` [alsa-devel][PATCH 1/4] ASoC: wm8960: codec mclk should be enabled early to avoid jack detect error Zidan Wang
2015-06-11 16:20 ` Mark Brown
2015-06-12 6:32 ` Zidan Wang
2015-06-12 10:33 ` Mark Brown
2015-06-16 9:30 ` Zidan Wang
2015-06-11 11:14 ` [alsa-devel][PATCH 2/4] ASoC: wm8960: support configure headphone jack detect pin and polarity from device tree Zidan Wang
2015-06-12 12:50 ` Charles Keepax
2015-06-16 7:47 ` Zidan Wang
2015-06-11 11:14 ` [alsa-devel][PATCH 3/4] ASoC: wm8960: add kcontrol to select ADC data output Zidan Wang
2015-06-12 12:29 ` Charles Keepax [this message]
2015-06-11 11:14 ` [alsa-devel][PATCH 4/4] ASoC: wm8960: the enum of "DAC Polarity" should be wm8960_enum[1] Zidan Wang
2015-06-12 12:31 ` Charles Keepax
2015-06-12 13:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612122918.GG32730@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=zidan.wang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox