public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: hekuang@huawei.com, jolsa@kernel.org, acme@redhat.com,
	a.p.zijlstra@chello.nl, lizefan@huawei.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH tip/perf/core] tools lib traceevent: Fix python/perf.so compiling error
Date: Fri, 12 Jun 2015 23:36:05 +0200	[thread overview]
Message-ID: <20150612213605.GD30061@krava.redhat.com> (raw)
In-Reply-To: <1434079031-123162-1-git-send-email-wangnan0@huawei.com>

On Fri, Jun 12, 2015 at 03:17:11AM +0000, Wang Nan wrote:
> 'make build-test' finds an error that make_python_perf_so fails due to
> missing of libtraceevent-dynamic-list:
> 
>  '.../python2' util/setup.py \
>    --quiet build_ext; \
>    mkdir -p python && \
>    cp python_ext_build/lib/perf.so python/
>    /path/to/ld: cannot open linker script file /path/to/kernel/tools/lib/traceevent/libtraceevent-dynamic-list: No such file or directory
>    collect2: error: ld returned 1 exit status
>    error: command 'x86_64-linux-gcc' failed with exit status 1
>    cp: cannot stat 'python_ext_build/lib/perf.so': No such file or directory
>    make[3]: *** [python/perf.so] Error 1
>    make[2]: *** [python/perf.so] Error 2
>      test: test -f ./python/perf.so
>      make[1]: *** [make_python_perf_so] Error 1
>      make: *** [build-test] Error 2
>      make: Leaving directory `/path/to/kernel/tools/perf'
> 
> This is caused by commit e3d09ec8126fe2c9a3ade661e2126e215ca27a80
> ("tools lib traceevent: Export dynamic symbols used by traceevent
> plugins") that, it adds the list file to LDFLAGS but forgot to add it
> to dependency list of python/perf.so.
> 
> This patch fixes this problem.
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

  reply	other threads:[~2015-06-12 21:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  3:17 [PATCH tip/perf/core] tools lib traceevent: Fix python/perf.so compiling error Wang Nan
2015-06-12 21:36 ` Jiri Olsa [this message]
2015-06-18  8:13 ` [tip:perf/core] tools lib traceevent: Fix python/ perf.so " tip-bot for Wang Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150612213605.GD30061@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox