From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551AbbFMAFR (ORCPT ); Fri, 12 Jun 2015 20:05:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36781 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754829AbbFMAFP (ORCPT ); Fri, 12 Jun 2015 20:05:15 -0400 Date: Fri, 12 Jun 2015 17:05:15 -0700 From: Greg Kroah-Hartman To: Ian Abbott Cc: driverdev-devel@linuxdriverproject.org, H Hartley Sweeten , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: cb_pcimdas: fix handlers for DI and DO subdevices Message-ID: <20150613000515.GA20155@kroah.com> References: <1434123461-20491-1-git-send-email-abbotti@mev.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434123461-20491-1-git-send-email-abbotti@mev.co.uk> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 04:37:41PM +0100, Ian Abbott wrote: > Normally, low-level Comedi drivers set an `insn_bits` handler for > digital input (DI), digital output (DO) and digital input/output (DIO) > subdevice types to handle normal reading and writing of digital > channels. The "cb_pcimdas" driver currently has an `insn_read` handler > for the DI subdevice and an `insn_write` handler for the DO subdevice. > However, the actual handler functions `cb_pcimdas_di_insn_read()` and > `cb_pcimdas_do_insn_write()` are written to behave like `insn_bits` > handlers. Something's wrong there! To fix it, set the functions as > `insn_bits` handlers and rename them for consistency. > > Fixes: e56d03dee14a ("staging: comedi: cb_pcimdas: add main connector digital input/output") > Signed-off-by: Ian Abbott > --- > I left the "Fixes:" line non-line-wrapped. Is that the correct thing to > do? Sure, that's fine, thanks. greg k-h