From: Frederic Weisbecker <fweisbec@gmail.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>, LKP <lkp@01.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [sched/preempt] BUG: KASan: out of bounds access in trace_graph_entry at addr ffff88000d717e48
Date: Sun, 14 Jun 2015 14:33:32 +0200 [thread overview]
Message-ID: <20150614123331.GA14645@lerouge> (raw)
In-Reply-To: <20150614085559.GB1911@wfg-t540p.sh.intel.com>
On Sun, Jun 14, 2015 at 04:55:59PM +0800, Fengguang Wu wrote:
> Hi Frederic,
>
> FYI, there are a number more bug messages showing up after this commit
>
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>
> commit b30f0e3ffedfa52b1d67a302ae5860c49998e5e2
> Author: Frederic Weisbecker <fweisbec@gmail.com>
> AuthorDate: Tue May 12 16:41:49 2015 +0200
> Commit: Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue May 19 08:39:12 2015 +0200
>
> sched/preempt: Optimize preemption operations on __schedule() callers
>
> __schedule() disables preemption and some of its callers
> (the preempt_schedule*() family) also set PREEMPT_ACTIVE.
>
> So we have two preempt_count() modifications that could be performed
> at once.
>
> Lets remove the preemption disablement from __schedule() and pull
> this responsibility to its callers in order to optimize preempt_count()
> operations in a single place.
>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Link: http://lkml.kernel.org/r/1431441711-29753-5-git-send-email-fweisbec@gmail.com
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
Do you still see that issue after latest tip:/sched/core. I fixed it a few days ago with:
9a92e3dc6ad02208a014d0d8404ebbd697e3d5ef (preempt: Reorganize the notrace definitions a bit)
4eaca0a887eaee04fc7a3866d0f5b51b34030dfa (preempt: Use preempt_schedule_context() as the official tracing preemption point)
be690035df893385ceaac2323b29be1fb7f2a67f (sched: Make preempt_schedule_context() function-tracing safe)
But maybe there are other issues remaining.
Thanks.
next prev parent reply other threads:[~2015-06-14 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 8:55 [sched/preempt] BUG: KASan: out of bounds access in trace_graph_entry at addr ffff88000d717e48 Fengguang Wu
2015-06-14 12:33 ` Frederic Weisbecker [this message]
2015-06-15 0:57 ` Fengguang Wu
2015-06-16 13:20 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150614123331.GA14645@lerouge \
--to=fweisbec@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox