* [PATCH] pktgen: fix typos in pktgen_bench_xmit_mode_netif_receive.sh
@ 2015-06-14 9:43 Igor Vuk
2015-06-14 16:59 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 2+ messages in thread
From: Igor Vuk @ 2015-06-14 9:43 UTC (permalink / raw)
To: davem; +Cc: brouer, linux-kernel, Igor Vuk
Fixes some typos in pktgen_bench_xmit_mode_netif_receive.sh,
also does some minor reformatting so the original layout is
preserved.
Signed-off-by: Igor Vuk <parcijala@gmail.com>
---
samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh b/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
index cb15903..a25525e 100755
--- a/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
+++ b/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
@@ -7,9 +7,9 @@
# "xmit_mode netif_receive". With an invalid dst_mac this will only
# measure the ingress code path as packets gets dropped in ip_rcv().
#
-# This script don't really need any hardware. It benchmarks software
-# RX path just after NIC driver level. With bursting is also
-# "removes" the SKB alloc/free overhead.
+# This script doesn't really need any hardware. It benchmarks
+# software RX path just after NIC driver level. With bursting it
+# also "removes" the SKB alloc/free overhead.
#
# Setup scenarios for measuring ingress qdisc (with invalid dst_mac):
# ------------------------------------------------------------------
@@ -69,7 +69,7 @@ for ((thread = 0; thread < $THREADS; thread++)); do
# Inject packet into RX path of stack
pg_set $dev "xmit_mode netif_receive"
- # Burst allow us to avoid measuring SKB alloc/free overhead
+ # Burst allows us to avoid measuring SKB alloc/free overhead
pg_set $dev "burst $BURST"
done
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pktgen: fix typos in pktgen_bench_xmit_mode_netif_receive.sh
2015-06-14 9:43 [PATCH] pktgen: fix typos in pktgen_bench_xmit_mode_netif_receive.sh Igor Vuk
@ 2015-06-14 16:59 ` Jesper Dangaard Brouer
0 siblings, 0 replies; 2+ messages in thread
From: Jesper Dangaard Brouer @ 2015-06-14 16:59 UTC (permalink / raw)
To: Igor Vuk; +Cc: davem, linux-kernel, brouer
On Sun, 14 Jun 2015 11:43:38 +0200
Igor Vuk <parcijala@gmail.com> wrote:
> Fixes some typos in pktgen_bench_xmit_mode_netif_receive.sh,
> also does some minor reformatting so the original layout is
> preserved.
>
> Signed-off-by: Igor Vuk <parcijala@gmail.com>
> ---
> samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh b/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
> index cb15903..a25525e 100755
> --- a/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
> +++ b/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
> @@ -7,9 +7,9 @@
> # "xmit_mode netif_receive". With an invalid dst_mac this will only
> # measure the ingress code path as packets gets dropped in ip_rcv().
> #
> -# This script don't really need any hardware. It benchmarks software
> -# RX path just after NIC driver level. With bursting is also
> -# "removes" the SKB alloc/free overhead.
> +# This script doesn't really need any hardware. It benchmarks
> +# software RX path just after NIC driver level. With bursting it
> +# also "removes" the SKB alloc/free overhead.
> #
> # Setup scenarios for measuring ingress qdisc (with invalid dst_mac):
> # ------------------------------------------------------------------
> @@ -69,7 +69,7 @@ for ((thread = 0; thread < $THREADS; thread++)); do
> # Inject packet into RX path of stack
> pg_set $dev "xmit_mode netif_receive"
>
> - # Burst allow us to avoid measuring SKB alloc/free overhead
> + # Burst allows us to avoid measuring SKB alloc/free overhead
> pg_set $dev "burst $BURST"
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-14 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-14 9:43 [PATCH] pktgen: fix typos in pktgen_bench_xmit_mode_netif_receive.sh Igor Vuk
2015-06-14 16:59 ` Jesper Dangaard Brouer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox