From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbbFNQ7m (ORCPT ); Sun, 14 Jun 2015 12:59:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40547 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbbFNQ7d (ORCPT ); Sun, 14 Jun 2015 12:59:33 -0400 Date: Sun, 14 Jun 2015 18:59:28 +0200 From: Jesper Dangaard Brouer To: Igor Vuk Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, brouer@redhat.com Subject: Re: [PATCH] pktgen: fix typos in pktgen_bench_xmit_mode_netif_receive.sh Message-ID: <20150614185928.3af7d546@redhat.com> In-Reply-To: <1434275018-14940-1-git-send-email-parcijala@gmail.com> References: <1434275018-14940-1-git-send-email-parcijala@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 14 Jun 2015 11:43:38 +0200 Igor Vuk wrote: > Fixes some typos in pktgen_bench_xmit_mode_netif_receive.sh, > also does some minor reformatting so the original layout is > preserved. > > Signed-off-by: Igor Vuk > --- > samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh b/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh > index cb15903..a25525e 100755 > --- a/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh > +++ b/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh > @@ -7,9 +7,9 @@ > # "xmit_mode netif_receive". With an invalid dst_mac this will only > # measure the ingress code path as packets gets dropped in ip_rcv(). > # > -# This script don't really need any hardware. It benchmarks software > -# RX path just after NIC driver level. With bursting is also > -# "removes" the SKB alloc/free overhead. > +# This script doesn't really need any hardware. It benchmarks > +# software RX path just after NIC driver level. With bursting it > +# also "removes" the SKB alloc/free overhead. > # > # Setup scenarios for measuring ingress qdisc (with invalid dst_mac): > # ------------------------------------------------------------------ > @@ -69,7 +69,7 @@ for ((thread = 0; thread < $THREADS; thread++)); do > # Inject packet into RX path of stack > pg_set $dev "xmit_mode netif_receive" > > - # Burst allow us to avoid measuring SKB alloc/free overhead > + # Burst allows us to avoid measuring SKB alloc/free overhead > pg_set $dev "burst $BURST" Acked-by: Jesper Dangaard Brouer -- Best regards, Jesper Dangaard Brouer MSc.CS, Sr. Network Kernel Developer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer