From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753894AbbFODem (ORCPT ); Sun, 14 Jun 2015 23:34:42 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:56009 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753730AbbFODeh (ORCPT ); Sun, 14 Jun 2015 23:34:37 -0400 Date: Mon, 15 Jun 2015 05:28:42 +0200 From: Andrew Lunn To: Joe Perches Cc: Jason Cooper , Sebastian Hesselbarth , Gregory Clement , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: orion5x: Use vsprintf %pM extension Message-ID: <20150615032842.GD10886@lunn.ch> References: <1434333690.2507.30.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434333690.2507.30.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 14, 2015 at 07:01:30PM -0700, Joe Perches wrote: > Format mac addresses with the normal kernel extension. > > Signed-off-by: Joe Perches Acked-by: Andrew Lunn Andrew > --- > arch/arm/mach-orion5x/dns323-setup.c | 4 +--- > arch/arm/mach-orion5x/tsx09-common.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/mach-orion5x/dns323-setup.c b/arch/arm/mach-orion5x/dns323-setup.c > index 09d2a26..f267e58 100644 > --- a/arch/arm/mach-orion5x/dns323-setup.c > +++ b/arch/arm/mach-orion5x/dns323-setup.c > @@ -236,9 +236,7 @@ static int __init dns323_read_mac_addr(void) > } > > iounmap(mac_page); > - printk("DNS-323: Found ethernet MAC address: "); > - for (i = 0; i < 6; i++) > - printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n"); > + printk("DNS-323: Found ethernet MAC address: %pM\n", addr); > > memcpy(dns323_eth_data.mac_addr, addr, 6); > > diff --git a/arch/arm/mach-orion5x/tsx09-common.c b/arch/arm/mach-orion5x/tsx09-common.c > index 7189827..24b2959 100644 > --- a/arch/arm/mach-orion5x/tsx09-common.c > +++ b/arch/arm/mach-orion5x/tsx09-common.c > @@ -101,9 +101,7 @@ static int __init qnap_tsx09_check_mac_addr(const char *addr_str) > addr[i] = byte; > } > > - printk(KERN_INFO "tsx09: found ethernet mac address "); > - for (i = 0; i < 6; i++) > - printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n"); > + printk(KERN_INFO "tsx09: found ethernet mac address %pM\n", addr); > > memcpy(qnap_tsx09_eth_data.mac_addr, addr, 6); > > >