From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752970AbbFOEgM (ORCPT ); Mon, 15 Jun 2015 00:36:12 -0400 Received: from imap.thunk.org ([74.207.234.97]:35231 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbbFOEgG (ORCPT ); Mon, 15 Jun 2015 00:36:06 -0400 Date: Mon, 15 Jun 2015 00:36:05 -0400 From: "Theodore Ts'o" To: Rasmus Villemoes Cc: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: ext4: mballoc: avoid 20-argument function call Message-ID: <20150615043605.GA15413@thunk.org> Mail-Followup-To: Theodore Ts'o , Rasmus Villemoes , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <1433975282-20694-1-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433975282-20694-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 11, 2015 at 12:28:02AM +0200, Rasmus Villemoes wrote: > Making a function call with 20 arguments is rather expensive in both > stack and .text. In this case, doing the formatting manually doesn't > make it any less readable, so we might as well save 155 bytes of .text > and 112 bytes of stack. > > Signed-off-by: Rasmus Villemoes Thanks, applied. - Ted