Re: [PATCH v7 0/8] mfd: cros_ec: Add multi EC and proto v3 support

Javier Martinez Canillas
2015-06-11T12:05:24Z

Hello Heiko,

On 06/11/2015 01:50 PM, Heiko Stübner wrote:
> Am Dienstag, 9. Juni 2015, 13:04:41 schrieb Javier Martinez Canillas:
>> Hello,
>>
>> This is a v7 of a series that adds support for multiple EC in a system
>> and also for the protocol version 3 that is used on newer ECs.
>>
>> Most patches were taken from the downstream ChromiumOS v3.14 tree with
>> fixes squashed, split to minimise the cross subsystem churn and changes
>> for mainline inclusion but were not modified functionality wise.
>>
>> This version addresses issues pointed out by Lee Jones on the v6 posted
>> before [0] and also adds the Acked-by tags of all the needed maintainers.
>>
>> The patches are based on top of "[PATCH 0/2] mfd: cros_ec: Small cleanups"
>> [1] that were posted before and already picked by Lee Jones.
>>
>> Testing was done on some Chromebooks that have a single EC and support
>> protocol v2 such as the Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800
>> Peach Pi to be sure that no regressions were introduced for these machines.
>>
>> The series were tested using a modified ectool [2] that supports the new
>> cros_ec IOCTL API. They were also tested on a x86 Pixel Chromebook 2 (Samus)
>> that uses the new protocol v3 and has 2 EC (cros_ec and cros_pd). But for
>> testing on Samus, also the posted "[PATCH 0/3] platform/chrome: Changes for
>> cros_ec_lpc and cros_ec_dev" series [3] are needed.
>
> everything still works as expected on a rk3288-veyron-jerry
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> [tags are already present in the patches]
>
>

Thanks a lot for testing again the patches.

> As the series now has Olof's Ack, can this still make it in time for 4.2 - as
> there is still a bit more than a week left till the merge window?
>

I hope so, the patch series have been in the lists for months now and been
tested and reviewed in extensively. I also made sure that it doesn't cause
any regressions on older Chromebook so it should be safe to pick for 4.2

>
> Heiko
>

Best regards,
Javier