From: Peter Zijlstra <peterz@infradead.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Amir Vadai <amirv@mellanox.com>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH resend] cpumask: don't perform while loop in cpumask_next_and()
Date: Mon, 15 Jun 2015 15:12:21 +0200 [thread overview]
Message-ID: <20150615131221.GA12596@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1425223323-20180-1-git-send-email-sergey.senozhatsky@gmail.com>
On Mon, Mar 02, 2015 at 12:22:03AM +0900, Sergey Senozhatsky wrote:
> +++ b/lib/cpumask.c
> @@ -37,10 +37,11 @@ EXPORT_SYMBOL(__next_cpu_nr);
> int cpumask_next_and(int n, const struct cpumask *src1p,
> const struct cpumask *src2p)
> {
> + struct cpumask tmp;
> +
> + if (cpumask_and(&tmp, src1p, src2p))
> + return cpumask_next(n, &tmp);
> + return nr_cpu_ids;
> }
> EXPORT_SYMBOL(cpumask_next_and);
Just ran into this; I though we were not supposed to put cpumasks on the
stack because $BIG. ?!
explain.
next prev parent reply other threads:[~2015-06-15 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 15:22 [PATCH resend] cpumask: don't perform while loop in cpumask_next_and() Sergey Senozhatsky
2015-06-15 13:12 ` Peter Zijlstra [this message]
2015-06-15 13:40 ` Borislav Petkov
2015-06-15 14:33 ` Sergey Senozhatsky
2015-06-15 14:43 ` Borislav Petkov
2015-06-15 14:26 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615131221.GA12596@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox