From: Ingo Molnar <mingo@kernel.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@amacapital.net>,
Oleg Nesterov <oleg@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Alexei Starovoitov <ast@plumgrid.com>,
Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/asm/entry/32, selftests: Add test_syscall_vdso test
Date: Mon, 15 Jun 2015 22:25:14 +0200 [thread overview]
Message-ID: <20150615202514.GC12450@gmail.com> (raw)
In-Reply-To: <557D7878.5000105@redhat.com>
* Denys Vlasenko <dvlasenk@redhat.com> wrote:
> On 06/13/2015 08:39 AM, Ingo Molnar wrote:
> >
> > * Denys Vlasenko <dvlasenk@redhat.com> wrote:
> >
> >> The test is fairly simplistic: it checks that all registers
> >> are preserved across 32-bit syscall via VDSO.
> >>
> >> Run-tested:
> >>
> >> $ ./test_syscall_vdso_32
> >> [RUN] Executing 6-argument 32-bit syscall via VDSO
> >> [Ok] Arguments are preserved across syscall
> >> [RUN] Executing 6-argument 32-bit syscall via INT 80
> >> [Ok] Arguments are preserved across syscall
> >> [RUN] Running tests under ptrace
> >> [RUN] Executing 6-argument 32-bit syscall via VDSO
> >> [Ok] Arguments are preserved across syscall
> >> [RUN] Executing 6-argument 32-bit syscall via INT 80
> >> [Ok] Arguments are preserved across syscall
> >
> > Just curious: is there a kernel sha1 where this test would fail? Or did you try to
> > provoke an information leak perhaps?
>
> I did see failures, more than once, when testing my own patches.
Ok!
> I'm not aware of released kernels which are buggy wrt this test.
Great! :-)
Thanks,
Ingo
prev parent reply other threads:[~2015-06-15 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 15:29 [PATCH v2] x86/asm/entry/32, selftests: Add test_syscall_vdso test Denys Vlasenko
2015-06-12 15:40 ` Denys Vlasenko
2015-06-13 6:39 ` Ingo Molnar
2015-06-14 12:50 ` Denys Vlasenko
2015-06-15 20:25 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615202514.GC12450@gmail.com \
--to=mingo@kernel.org \
--cc=ast@plumgrid.com \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox