From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756129AbbFOU3N (ORCPT ); Mon, 15 Jun 2015 16:29:13 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:58777 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755876AbbFOU3E (ORCPT ); Mon, 15 Jun 2015 16:29:04 -0400 Date: Mon, 15 Jun 2015 13:29:03 -0700 From: Darren Hart To: Arnd Bergmann Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Ike Panhc , Darren Hart , Matthew Garrett Subject: Re: [PATCH 1/2] ideapad: fix software rfkill setting Message-ID: <20150615202903.GC83198@vmdeb7> References: <5498848.9yV42J8a1L@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5498848.9yV42J8a1L@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 13, 2015 at 03:23:33PM +0200, Arnd Bergmann wrote: > This fixes a several year old regression that I found while trying > to get the Yoga 3 11 to work. The ideapad_rfk_set function is meant > to send a command to the embedded controller through ACPI, but > as of c1f73658ed, it sends the index of the rfkill device instead > of the command, and ignores the opcode field. > > This changes it back to the original behavior, which indeed > flips the rfkill state as seen in the debugfs interface. > > Signed-off-by: Arnd Bergmann > Fixes: c1f73658ed ("ideapad: pass ideapad_priv as argument (part 2)") > Cc: stable@vger.kernel.org # v2.6.38+ Queued for 4.2. Thanks! -- Darren Hart Intel Open Source Technology Center