From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755943AbbFOVdr (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Jun 2015 17:33:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46972 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751836AbbFOVdj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Jun 2015 17:33:39 -0400
Date: Mon, 15 Jun 2015 23:33:32 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 03/30] perf tools: Change thread_map::map into struct
Message-ID: <20150615213332.GC6458@krava.redhat.com>
References: <1434269985-521-1-git-send-email-jolsa@kernel.org>
 <1434269985-521-4-git-send-email-jolsa@kernel.org>
 <20150615190404.GC5845@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150615190404.GC5845@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 15, 2015 at 04:04:04PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Jun 14, 2015 at 10:19:18AM +0200, Jiri Olsa escreveu:
> > We need to store command names with the pid. Changing
> > map to be struct holding pid. Process name is coming
> > in shortly.
> 
> <SNIP>
>  
> > +++ b/tools/perf/util/thread_map.h
> > @@ -4,11 +4,17 @@
> >  #include <sys/types.h>
> >  #include <stdio.h>
> >  
> > +struct thread_map_data {
> > +	pid_t    pid;
> > +};
> > +
> 
> What 'data' is this? That is way vague term.

data related to thread_mmap ;-)

jirka

> 
>  Will try looking at the other patches to try to suggest some other name
> for this :-\
> 
> >  struct thread_map {
> >  	int nr;
> > -	pid_t map[];
> > +	struct thread_map_data map[];
> >  };
> >  
> > +#define thread_map__pid(__m, __t)  __m->map[__t].pid
> > +
> >  struct thread_map *thread_map__new_dummy(void);
> >  struct thread_map *thread_map__new_by_pid(pid_t pid);
> >  struct thread_map *thread_map__new_by_tid(pid_t tid);
> > -- 
> > 1.9.3