From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: "Abdul, Hussain (H.)" <habdul@visteon.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Dighe, Niranjan (N.)" <ndighe@visteon.com>,
"chris.park@atmel.com" <chris.park@atmel.com>,
"Ravindran, Madhusudhanan (M.)" <mravindr@visteon.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"johnny.kim@atmel.com" <johnny.kim@atmel.com>,
"rachel.kim@atmel.com" <rachel.kim@atmel.com>,
"dean.lee@atmel.com" <dean.lee@atmel.com>
Subject: Re: [PATCH] Staging: wilc1000: Boolean tests don't need comparisons
Date: Tue, 16 Jun 2015 13:39:55 +0530 [thread overview]
Message-ID: <20150616080955.GA1007@sudip-PC> (raw)
In-Reply-To: <1434439941-6369-1-git-send-email-habdul@visteon.com>
On Tue, Jun 16, 2015 at 07:33:42AM +0000, Abdul, Hussain (H.) wrote:
> From: Abdul Hussain <habdul@visteon.com>
>
> This patch removes unwanted true and false from boolean tests.
>
> Signed-off-by: Abdul Hussain <habdul@visteon.com>
> ---
<snip>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 17ab5cd..be1f6bf 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -7816,7 +7816,7 @@ static void *host_int_ParseJoinBssParam(tstrNetworkInfo *ptstrNetworkInfo)
> pNewJoinBssParam->rsn_cap[1] = pu8IEs[rsnIndex + 1];
> rsnIndex += 2;
> }
> - pNewJoinBssParam->rsn_found = 1;
> + pNewJoinBssParam->rsn_found = true;
But this is not a boolean test, this is an assignement.
regards
sudip
next prev parent reply other threads:[~2015-06-16 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 7:33 [PATCH] Staging: wilc1000: Boolean tests don't need comparisons Abdul, Hussain (H.)
2015-06-16 8:09 ` Sudip Mukherjee [this message]
2015-06-16 8:55 ` Abdul, Hussain (H.)
2015-06-16 11:11 ` Sudip Mukherjee
2015-06-16 12:24 ` Abdul, Hussain (H.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616080955.GA1007@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=habdul@visteon.com \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mravindr@visteon.com \
--cc=ndighe@visteon.com \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox