From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: "Abdul, Hussain (H.)" <habdul@visteon.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Dighe, Niranjan (N.)" <ndighe@visteon.com>,
"chris.park@atmel.com" <chris.park@atmel.com>,
"Ravindran, Madhusudhanan (M.)" <mravindr@visteon.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"johnny.kim@atmel.com" <johnny.kim@atmel.com>,
"rachel.kim@atmel.com" <rachel.kim@atmel.com>,
"dean.lee@atmel.com" <dean.lee@atmel.com>
Subject: Re: [PATCH] Staging: wilc1000: Boolean tests don't need comparisons
Date: Tue, 16 Jun 2015 16:41:11 +0530 [thread overview]
Message-ID: <20150616111111.GA15479@sudip-PC> (raw)
In-Reply-To: <DB5PR06MB1112E576BF6FFE240CB124C0DFA70@DB5PR06MB1112.eurprd06.prod.outlook.com>
On Tue, Jun 16, 2015 at 08:55:13AM +0000, Abdul, Hussain (H.) wrote:
> On Tuesday 16 June 2015 01:40 PM, Sudip Mukherjee wrote:
> > On Tue, Jun 16, 2015 at 07:33:42AM +0000, Abdul, Hussain (H.) wrote:
> >> From: Abdul Hussain <habdul@visteon.com>
> >
> > regards
> > sudip
> >
> Sudip,
>
> Yes that is an assignment to the boolean variable. Do i need to modify the commit message or to send separate patch?
if that assignment is related to the change in boolean test then it should
be in the same patch. But in any case commit message should mention that
change and the reason.
regards
sudip
next prev parent reply other threads:[~2015-06-16 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 7:33 [PATCH] Staging: wilc1000: Boolean tests don't need comparisons Abdul, Hussain (H.)
2015-06-16 8:09 ` Sudip Mukherjee
2015-06-16 8:55 ` Abdul, Hussain (H.)
2015-06-16 11:11 ` Sudip Mukherjee [this message]
2015-06-16 12:24 ` Abdul, Hussain (H.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616111111.GA15479@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=habdul@visteon.com \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mravindr@visteon.com \
--cc=ndighe@visteon.com \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox