From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Hou Pengyang <houpengyang@huawei.com>
Cc: namhyung@kernel.org, mingo@redhat.com, wangnan0@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf unwind: Fix a compile error
Date: Tue, 16 Jun 2015 10:47:50 -0300 [thread overview]
Message-ID: <20150616134750.GC10374@kernel.org> (raw)
In-Reply-To: <1434453395-10560-1-git-send-email-houpengyang@huawei.com>
Em Tue, Jun 16, 2015 at 11:16:35AM +0000, Hou Pengyang escreveu:
> When libunwind is on, there is a compile error as :
>
> util/unwind-libunwind.c:363:21: error: 'dso' undeclared (first use in this function)
> dso__data_put_fd(dso);
>
> This patch fix it.
Thanks, applied.
- Arnaldo
> Fixes: 4bb11d012ab248d0 ("perf tools: Add dso__data_get/put_fd()")
> Signed-off-by: Hou Pengyang <houpengyang@huawei.com>
> ---
> tools/perf/util/unwind-libunwind.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c
> index f079b63..4c00507 100644
> --- a/tools/perf/util/unwind-libunwind.c
> +++ b/tools/perf/util/unwind-libunwind.c
> @@ -360,7 +360,7 @@ find_proc_info(unw_addr_space_t as, unw_word_t ip, unw_proc_info_t *pi,
> unw_word_t base = is_exec ? 0 : map->start;
>
> if (fd >= 0)
> - dso__data_put_fd(dso);
> + dso__data_put_fd(map->dso);
>
> memset(&di, 0, sizeof(di));
> if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->name,
> --
> 1.8.5.2
next prev parent reply other threads:[~2015-06-16 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 11:16 [PATCH] perf unwind: Fix a compile error Hou Pengyang
2015-06-16 13:47 ` Arnaldo Carvalho de Melo [this message]
2015-06-17 11:51 ` Wangnan (F)
2015-06-17 19:35 ` Arnaldo Carvalho de Melo
2015-06-18 8:15 ` [tip:perf/core] " tip-bot for Hou Pengyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616134750.GC10374@kernel.org \
--to=acme@kernel.org \
--cc=houpengyang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox