From: Andi Kleen <andi@firstfloor.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: David Ahern <dsahern@gmail.com>,
"Liang, Kan" <kan.liang@intel.com>,
Andi Kleen <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Huang, Ying" <ying.huang@intel.com>
Subject: Re: [PATCH 1/1] perf,tools: add time out to force stop endless mmap processing
Date: Tue, 16 Jun 2015 17:44:22 +0200 [thread overview]
Message-ID: <20150616154422.GA19417@two.firstfloor.org> (raw)
In-Reply-To: <20150616151159.GF10374@kernel.org>
> Perhaps we should add a per-thread-proc-map-processing timeout parameter
> to the synthesizing routines instead of having that hardcoded, i.e.
> allow the tool to specify what is reasonable for it, but that wouldn't
> be strictly required for a first patch, emitting the dialog box above
> after synthesizing, if truncation happened, is.
>
> Agreed?
If you make top emit a dialog box please make it appear only once and have a
timeout so that it doesn't block it forever
I personally would prefer of top just doing best effort and not giving
such warnings which the user cannot do anything about anyways.
-Andi
next prev parent reply other threads:[~2015-06-16 15:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 7:46 [PATCH 1/1] perf,tools: add time out to force stop endless mmap processing kan.liang
2015-06-11 14:06 ` Arnaldo Carvalho de Melo
2015-06-11 14:27 ` Liang, Kan
2015-06-11 15:37 ` Arnaldo Carvalho de Melo
2015-06-11 15:21 ` David Ahern
2015-06-11 18:47 ` Andi Kleen
2015-06-12 0:33 ` David Ahern
2015-06-12 14:42 ` Liang, Kan
2015-06-12 15:41 ` David Ahern
2015-06-12 17:05 ` Liang, Kan
2015-06-12 17:28 ` David Ahern
2015-06-12 18:19 ` Liang, Kan
2015-06-12 19:29 ` David Ahern
2015-06-12 19:45 ` Andi Kleen
2015-06-12 20:39 ` Liang, Kan
2015-06-12 20:52 ` David Ahern
2015-06-12 22:41 ` Liang, Kan
2015-06-13 4:07 ` David Ahern
2015-06-13 14:59 ` Liang, Kan
2015-06-13 4:24 ` David Ahern
2015-06-13 15:06 ` Liang, Kan
2015-06-16 15:11 ` Arnaldo Carvalho de Melo
2015-06-16 15:44 ` Andi Kleen [this message]
2015-06-16 15:57 ` David Ahern
2015-06-16 16:42 ` Liang, Kan
2015-06-16 18:08 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616154422.GA19417@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox