Re: [PATCH 1/3] kdbus: kdbus_reply_find(): return on found entry

David Herrmann
2015-06-17T17:22:11Z

Hi

On Wed, Jun 17, 2015 at 7:14 PM, Sergei Zviagintsev <sergei@s15v.net> wrote:
> Return found entry immediately instead of assigning it to additional
> variable and breaking the loop. It's simpler to read, the same way is
> used in kdbus_conn_has_name(), for example.
>
> Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
> ---
> ipc/kdbus/reply.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)

Yeah, left-over from reply->mutex.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> diff --git a/ipc/kdbus/reply.c b/ipc/kdbus/reply.c
> index 89d355b44f63..9d823ebee71f 100644
> --- a/ipc/kdbus/reply.c
> +++ b/ipc/kdbus/reply.c
> @@ -171,17 +171,15 @@ struct kdbus_reply *kdbus_reply_find(struct kdbus_conn *replying,
> struct kdbus_conn *reply_dst,
> u64 cookie)
> {
> - struct kdbus_reply *r, *reply = NULL;
> + struct kdbus_reply *r;
>
> list_for_each_entry(r, &reply_dst->reply_list, entry) {
> if (r->cookie == cookie &&
> - (!replying || r->reply_src == replying)) {
> - reply = r;
> - break;
> - }
> + (!replying || r->reply_src == replying))
> + return r;
> }
>
> - return reply;
> + return NULL;
> }
>
> /**
> --
> 1.8.3.1
>