Re: [PATCH] perf tools: Move libtraceevent dynamic list to separated LDFLAGS variable

Jiri Olsa
2015-06-17T18:29:01Z

On Wed, Jun 17, 2015 at 02:46:29PM +0000, Wang Nan wrote:
> Commit e3d09ec8126fe2c9a3ade661e2126e215ca27a80 ("tools lib traceevent:
> Export dynamic symbols used by traceevent plugins") adds libtraceevent
> dynamic list directly into LDFLAGS, which makes all targets depend on
> that list through LDFLAGS. This is not good since some of targets like
> libgtk.so doesn't use plugin at all, but require the existance of that
> list because of linker options.
>
> This patch isolates the -Xlink option into LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS,
> makes only perf and perf.so use it.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka