From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@kernel.org, mgorman@suse.de
Subject: Re: [PATCH] sched,numa: document and fix numa_preferred_nid setting
Date: Thu, 18 Jun 2015 21:25:47 +0530 [thread overview]
Message-ID: <20150618155547.GA16576@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150616155450.62ec234b@cuia.usersys.redhat.com>
> if (p->numa_group) {
> if (env.best_cpu == -1)
> @@ -1513,7 +1520,7 @@ static int task_numa_migrate(struct task_struct *p)
> nid = env.dst_nid;
>
> if (node_isset(nid, p->numa_group->active_nodes))
> - sched_setnuma(p, env.dst_nid);
> + sched_setnuma(p, nid);
> }
>
> /* No better CPU than the current one was found. */
>
Overall this patch does seem to produce better results. However numa02
gets affected -vely.
KernelVersion: 4.1.0-rc7-tip
Testcase: Min Max Avg StdDev
elapsed_numa01: 858.85 949.18 915.64 33.06
elapsed_numa02: 23.09 29.89 26.43 2.18
Testcase: Min Max Avg StdDev
system_numa01: 1516.72 1855.08 1686.24 113.95
system_numa02: 63.69 79.06 70.35 5.87
Testcase: Min Max Avg StdDev
user_numa01: 73284.76 80818.21 78060.88 2773.60
user_numa02: 1690.18 2071.07 1821.64 140.25
Testcase: Min Max Avg StdDev
total_numa01: 74801.50 82572.60 79747.12 2875.61
total_numa02: 1753.87 2142.77 1891.99 143.59
KernelVersion: 4.1.0-rc7-tip + your patch
Testcase: Min Max Avg StdDev %Change
elapsed_numa01: 665.26 877.47 776.77 79.23 15.83%
elapsed_numa02: 24.59 31.30 28.17 2.48 -5.56%
Testcase: Min Max Avg StdDev %Change
system_numa01: 659.57 1220.99 942.36 234.92 60.92%
system_numa02: 44.62 86.01 64.64 14.24 6.64%
Testcase: Min Max Avg StdDev %Change
user_numa01: 56280.95 75908.81 64993.57 7764.30 17.21%
user_numa02: 1790.35 2155.02 1916.12 132.57 -4.38%
Testcase: Min Max Avg StdDev %Change
total_numa01: 56940.50 77128.20 65935.92 7993.49 17.91%
total_numa02: 1834.97 2227.03 1980.76 136.51 -3.99%
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2015-06-18 15:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 19:54 [PATCH] sched,numa: document and fix numa_preferred_nid setting Rik van Riel
2015-06-18 15:55 ` Srikar Dronamraju [this message]
2015-06-18 16:06 ` Rik van Riel
2015-06-18 16:41 ` Srikar Dronamraju
2015-06-18 17:00 ` Rik van Riel
2015-06-18 17:11 ` Srikar Dronamraju
2015-06-19 17:16 ` Srikar Dronamraju
2015-06-19 17:52 ` Rik van Riel
2015-06-22 16:04 ` Srikar Dronamraju
2015-06-22 16:48 ` Srikar Dronamraju
2015-06-18 16:12 ` Ingo Molnar
2015-06-18 18:16 ` Rik van Riel
2015-06-22 16:13 ` Srikar Dronamraju
2015-06-22 22:28 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618155547.GA16576@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox