From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756577AbbFRTbX (ORCPT ); Thu, 18 Jun 2015 15:31:23 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56658 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755104AbbFRTbO (ORCPT ); Thu, 18 Jun 2015 15:31:14 -0400 Date: Thu, 18 Jun 2015 12:31:13 -0700 From: Greg KH To: Alexandre Belloni Cc: Nicholas Krause , balbi@ti.com, nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, peter.chen@freescale.com, ronald.wahl@raritan.com, voice.shen@atmel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init Message-ID: <20150618193113.GA21756@kroah.com> References: <1430709902-10815-1-git-send-email-xerofoify@gmail.com> <20150618164114.GS27492@piout.net> <20150618190452.GT27492@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150618190452.GT27492@piout.net> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 18, 2015 at 09:04:52PM +0200, Alexandre Belloni wrote: > On 18/06/2015 at 18:41:14 +0200, Alexandre Belloni wrote : > > On 03/05/2015 at 23:25:02 -0400, Nicholas Krause wrote : > > > This simplifies the error checking of the function,at91sam9261_udc_init > > > by using PTR_ERR_OR_ZERO in the return statement rather then a unnessary > > > if statement to check the return value of a call to the function, > > > syscon_regmap_lookup_by_phandle by checking with a call to the function, > > > IS_ERR and returning a error pointer if there is one for the function, > > > at91sam9261_udc_init. Furthermore this was found by running coccinelle > > > against the lastest kernel tree. > > > > > > Signed-off-by: Nicholas Krause > > Acked-by: Alexandre Belloni > > > > OK, it seems the original patch got ignored by all the mailing lists. To > bad, that one was actually applicable :) Nick is banned from vger.kernel.org, so that is why his patches will not ever show up. I recommend that you do the same if possible. greg k-h