From: Stephen Boyd <sboyd@codeaurora.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Tero Kristo <t-kristo@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Dinh Nguyen <dinguyen@opensource.altera.com>
Subject: Re: [PATCH v3 1/7] clk: introduce clk_div_mask() helper
Date: Thu, 18 Jun 2015 12:48:16 -0700 [thread overview]
Message-ID: <20150618194815.GK29640@codeaurora.org> (raw)
In-Reply-To: <1427822547-163289-2-git-send-email-andriy.shevchenko@linux.intel.com>
On 03/31, Andy Shevchenko wrote:
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index 5591ea7..20b0b67 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -353,6 +353,11 @@ struct clk_divider {
> spinlock_t *lock;
> };
>
> +static inline unsigned long clk_div_mask(u8 width)
> +{
> + return (1 << width) - 1;
> +}
> +
Why not just change drivers to use GENMASK? It's a proven and
tested way to generate a bitmask.
So I'd rather see drivers converted to use that macro directly
especially because the mask may need to start at some bit that
isn't 0.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-06-18 19:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 17:22 [PATCH v3 0/7] clk: replace div_mask() by clk_div_mask() Andy Shevchenko
2015-03-31 17:22 ` [PATCH v3 1/7] clk: introduce clk_div_mask() helper Andy Shevchenko
2015-06-18 19:48 ` Stephen Boyd [this message]
2015-07-07 15:48 ` Andy Shevchenko
2015-07-07 23:26 ` Stephen Boyd
2015-03-31 17:22 ` [PATCH v3 2/7] clk: mmp: switch to clk_div_mask() Andy Shevchenko
2015-03-31 17:22 ` [PATCH v3 3/7] clk: divider: " Andy Shevchenko
2015-03-31 17:22 ` [PATCH v3 4/7] clk: socfpga: " Andy Shevchenko
2015-03-31 17:22 ` [PATCH v3 5/7] clk: ti: divider: " Andy Shevchenko
2015-03-31 17:22 ` [PATCH v3 6/7] clk: tegra: " Andy Shevchenko
2015-03-31 17:22 ` [PATCH v3 7/7] ARM: imx: " Andy Shevchenko
2015-03-31 17:44 ` [PATCH v3 0/7] clk: replace div_mask() by clk_div_mask() Russell King - ARM Linux
2015-05-06 12:36 ` Andy Shevchenko
2015-05-06 22:28 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618194815.GK29640@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dinguyen@opensource.altera.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pdeschrijver@nvidia.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox