From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756070AbbFRTsZ (ORCPT ); Thu, 18 Jun 2015 15:48:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60726 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753400AbbFRTsR (ORCPT ); Thu, 18 Jun 2015 15:48:17 -0400 Date: Thu, 18 Jun 2015 12:48:16 -0700 From: Stephen Boyd To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Sascha Hauer , Peter De Schrijver , Tero Kristo , Russell King , Dinh Nguyen Subject: Re: [PATCH v3 1/7] clk: introduce clk_div_mask() helper Message-ID: <20150618194815.GK29640@codeaurora.org> References: <1427822547-163289-1-git-send-email-andriy.shevchenko@linux.intel.com> <1427822547-163289-2-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427822547-163289-2-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/31, Andy Shevchenko wrote: > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h > index 5591ea7..20b0b67 100644 > --- a/include/linux/clk-provider.h > +++ b/include/linux/clk-provider.h > @@ -353,6 +353,11 @@ struct clk_divider { > spinlock_t *lock; > }; > > +static inline unsigned long clk_div_mask(u8 width) > +{ > + return (1 << width) - 1; > +} > + Why not just change drivers to use GENMASK? It's a proven and tested way to generate a bitmask. So I'd rather see drivers converted to use that macro directly especially because the mask may need to start at some bit that isn't 0. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project