public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified
Date: Thu, 18 Jun 2015 22:39:35 +0200	[thread overview]
Message-ID: <20150618203935.GA4806@wunner.de> (raw)
In-Reply-To: <55832971.4070603@gmail.com>

Hi David,

On Thu, Jun 18, 2015 at 02:26:25PM -0600, David Ahern wrote:
> It worked for me last week with OL6.
> I created a standalone perf rpm with 4.1-rc6; it builds just fine with
> _prefix (rpm variable) set to /usr:
[...]
> %global perf_make \
>   make -s -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1
> NO_GTK2=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=%{_prefix}
> %{perf_make} DESTDIR=$RPM_BUILD_ROOT all

You're not invoking tools/perf/Makefile.perf but tools/perf/Makefile
and I would say this in line 18 avoids that prefix= is passed down
to Makefile.perf:

	# We don't want to pass along options like -j:
	unexport MAKEFLAGS

Sources:
https://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/tools/perf/Makefile#n18

So the prefix parameter should have no effect at all in your case,
no matter to what you set it.

Best regards,

Lukas

  reply	other threads:[~2015-06-18 20:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201506181332.t5IDWuUq027242@int-mx13.intmail.prod.int.phx2.redhat.com>
2015-06-18 19:29 ` [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified Jiri Olsa
2015-06-18 19:59   ` Lukas Wunner
2015-06-18 20:26     ` David Ahern
2015-06-18 20:39       ` Lukas Wunner [this message]
2015-06-18 21:51         ` Jiri Olsa
2015-06-18 22:07         ` David Ahern
2015-06-18 22:17         ` Jiri Olsa
2015-06-19 11:54           ` Lukas Wunner
2015-06-19 14:19             ` Arnaldo Carvalho de Melo
2015-06-18 21:52 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150618203935.GA4806@wunner.de \
    --to=lukas@wunner.de \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox