From: Ingo Molnar <mingo@kernel.org>
To: Brian Gerst <brgerst@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Denys Vlasenko <dvlasenk@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
linux-tip-commits@vger.kernel.org
Subject: Re: [RFC] Rename various 'IA32' uses in arch/x86/ code
Date: Thu, 18 Jun 2015 23:13:18 +0200 [thread overview]
Message-ID: <20150618211318.GA3934@gmail.com> (raw)
In-Reply-To: <CAMzpN2h84qNNOzeuuf+=Yp=0OiDGDp2NsiWibB1_htirtQk5gA@mail.gmail.com>
* Brian Gerst <brgerst@gmail.com> wrote:
> >> The original one wasn't really a misnomer, as it referred to the ia32 system
> >> calls specifically, but this works too.
> >
> > It was a misnomer, because what are the 'ia32 system calls'? We have no Intel
> > specific system calls!
> >
> > The term 'IA32' (Intel Architecture 32-bit) is a misnomer in many existing
> > arch/x86/ symbol, function and file names, and most of them should be renamed.
> >
> > Some common examples, with a suggested rename target:
> >
> > stack_frame_ia32 -> stack_frame_compat
> > IA32_RT_SIGFRAME_sigcontext -> COMPAT_RT_SIGFRAME_sigcontext
> > sigcontext_ia32 -> sigcontext_compat
> > user_i387_ia32_struct -> user_i387_compat_struct
> > TIF_IA32 -> TIF_COMPAT
> >
> > and here a few 'ia32' misnomers that should be addressed not via simple renames,
> > but via transformations to existing compat facilities:
> >
> > CONFIG_IA32_EMULATION -> partly eliminate, partly covert to CONFIG_COMPAT use
>
> I think we still want a symbol for code that is exclusive to 32-bit
> compatibility (like entry and signal code) to keep it separate from X32 which
> also wants CONFIG_COMPAT. If I get time this weekend I'll get the patchset to
> do the separation updated to the tip branch.
Ok, so your goal is to allow the x32 ABI, but not 32-bit user-space?
I suppose that makes some sense, it might be a valid 'attack surface reduction'
technique, while still allowing the x32 ABI.
But I'm not sure we should bother and complicate things: 32-bit compat isn't going
away anytime soon, and most of CONFIG_COMPAT is needed for x32.
So maybe we could introduce CONFIG_X86_32_ABI=y or so, which would cover just the
32-bit entry code and the signal frame compatibility layer?
Thanks,
Ingo
next prev parent reply other threads:[~2015-06-18 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-bace7117d3fb59a6ed7ea1aa6c8994df6a28a72a@git.kernel.org>
2015-06-16 20:22 ` [tip:x86/asm] x86/asm/entry: (Re-) rename __NR_entry_INT80_compat_max to __NR_syscall_compat_max H. Peter Anvin
2015-06-18 16:49 ` [RFC] Rename various 'IA32' uses in arch/x86/ code Ingo Molnar
2015-06-18 17:49 ` Brian Gerst
2015-06-18 19:37 ` H. Peter Anvin
2015-06-19 7:13 ` Ingo Molnar
2015-06-19 17:19 ` H. Peter Anvin
2015-06-21 13:44 ` Ingo Molnar
[not found] ` <CA+55aFzKOyZ4ZA6zFvCNqqqkYT8hLQOXAgJRj-k+LRqvQ1iiyQ@mail.gmail.com>
2015-06-18 19:41 ` H. Peter Anvin
2015-06-18 21:13 ` Ingo Molnar [this message]
2015-06-18 22:11 ` Brian Gerst
2015-06-19 7:08 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618211318.GA3934@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).