Re: [RFC] hotkey for disabling/enabling events in 'perf top' TUI was Re: [GIT PULL 0/8] perf/core improvements and fixes

[Ingo Molnar <mingo@kernel.org>]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Thu, Jun 18, 2015 at 10:58:13PM +0200, Ingo Molnar escreveu:
> > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > > Btw., it would be nice if the status line carried information about whether 
> > > > collection is 'frozen' or running, at a glance. A hint might also suggest how to 
> > > > unfreeze the session - in case someone pressed Ctrl-Z to suspend the perf top 
> > > > session ...
> > > 
> > > Right, and I think we better find other hotkey and make Ctrl+Z work like
> > > with other tools, i.e. suspend:
> > > 
> > > [acme@zoo linux]$ mutt
> > > 
> > > [1]+  Stopped                 mutt
> > > [acme@zoo linux]$ vim
> > > 
> > > [2]+  Stopped                 vim
> > > [acme@zoo linux]$ 
> > > 
> > > The perf TUI should work like that as well...
> > > 
> > > Ideas?
> > > 
> > > We already have:
> > > 
> > > h/?/F1        Show this window
> > > UP/DOWN/PGUP
> <SNIP>
> > > z             Toggle zeroing of samples 
> > > /             Filter symbol by name 
> > 
> > Is 'f' (for 'freeze') still available?
> 
> It is available in both the 'report'/'top' (aka the "hists" browser) and in the 
> annotate browser, so I'll go with it, and leave CTRL+z alone, then make it it 
> suspend.

Sounds good to me!

Thanks,

	Ingo