From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753799AbbFSG1Y (ORCPT <rfc822;w@1wt.eu>);
	Fri, 19 Jun 2015 02:27:24 -0400
Received: from mail-wi0-f171.google.com ([209.85.212.171]:33875 "EHLO
	mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752006AbbFSG1Q (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 19 Jun 2015 02:27:16 -0400
Date: Fri, 19 Jun 2015 08:27:11 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>,
        Borislav Petkov <bp@suse.de>, David Ahern <dsahern@gmail.com>,
        Don Zickus <dzickus@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        He Kuang <hekuang@huawei.com>, Jiri Olsa <jolsa@redhat.com>,
        Li Zhang <zhlcindy@linux.vnet.ibm.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>, Naohiro Aota <naota@elisp.net>,
        Peter Zijlstra <peterz@infradead.org>, pi3orama@163.com,
        Stephane Eranian <eranian@google.com>,
        Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
        Wang Nan <wangnan0@huawei.com>, Zefan Li <lizefan@huawei.com>
Subject: Re: [RFC] hotkey for disabling/enabling events in 'perf top' TUI was
 Re: [GIT PULL 0/8] perf/core improvements and fixes
Message-ID: <20150619062711.GB9668@gmail.com>
References: <1434576155-30038-1-git-send-email-acme@kernel.org>
 <20150618074010.GA3194@gmail.com>
 <20150618201829.GF3079@kernel.org>
 <20150618205813.GA476@gmail.com>
 <20150618213949.GH3079@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150618213949.GH3079@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Thu, Jun 18, 2015 at 10:58:13PM +0200, Ingo Molnar escreveu:
> > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > > Btw., it would be nice if the status line carried information about whether 
> > > > collection is 'frozen' or running, at a glance. A hint might also suggest how to 
> > > > unfreeze the session - in case someone pressed Ctrl-Z to suspend the perf top 
> > > > session ...
> > > 
> > > Right, and I think we better find other hotkey and make Ctrl+Z work like
> > > with other tools, i.e. suspend:
> > > 
> > > [acme@zoo linux]$ mutt
> > > 
> > > [1]+  Stopped                 mutt
> > > [acme@zoo linux]$ vim
> > > 
> > > [2]+  Stopped                 vim
> > > [acme@zoo linux]$ 
> > > 
> > > The perf TUI should work like that as well...
> > > 
> > > Ideas?
> > > 
> > > We already have:
> > > 
> > > h/?/F1        Show this window
> > > UP/DOWN/PGUP
> <SNIP>
> > > z             Toggle zeroing of samples 
> > > /             Filter symbol by name 
> > 
> > Is 'f' (for 'freeze') still available?
> 
> It is available in both the 'report'/'top' (aka the "hists" browser) and in the 
> annotate browser, so I'll go with it, and leave CTRL+z alone, then make it it 
> suspend.

Sounds good to me!

Thanks,

	Ingo