public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified
Date: Fri, 19 Jun 2015 13:54:17 +0200	[thread overview]
Message-ID: <20150619115417.GA4897@wunner.de> (raw)
In-Reply-To: <20150618221304.GA27529@krava.redhat.com>

Hi Jiri, Hi David,

On Fri, Jun 19, 2015 at 12:17:06AM +0200, Jiri Olsa wrote:
> it had effect.. prefix is passed to build framework throught .config-detected
> file as prefix_SQ variable, which is then referenced in perf Build makefiles

You're right, thanks for the clarification.

The underlying issue is basically that the same variable name is used for
two different things, to calculate the paths of the build targets in
Makefile.build and to pass the install directory around between Makefiles.
And which one "wins" depends on invocation. If we just rename the variable
in Makefile.build, the issue is gone. That's what the patch does.

Thanks again,

Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2015-06-19 11:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201506181332.t5IDWuUq027242@int-mx13.intmail.prod.int.phx2.redhat.com>
2015-06-18 19:29 ` [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified Jiri Olsa
2015-06-18 19:59   ` Lukas Wunner
2015-06-18 20:26     ` David Ahern
2015-06-18 20:39       ` Lukas Wunner
2015-06-18 21:51         ` Jiri Olsa
2015-06-18 22:07         ` David Ahern
2015-06-18 22:17         ` Jiri Olsa
2015-06-19 11:54           ` Lukas Wunner [this message]
2015-06-19 14:19             ` Arnaldo Carvalho de Melo
2015-06-18 21:52 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150619115417.GA4897@wunner.de \
    --to=lukas@wunner.de \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox