public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andrey Ryabinin <a.ryabinin@samsung.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Alexander Popov <alpopov@ptsecurity.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Andrey Konovalov <adech.fo@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Lutomirski <luto@kernel.org>,
	Alexander Kuleshov <kuleshovmail@gmail.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Kees Cook <keescook@chromium.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/1] x86_64: fix KASan shadow region page tables
Date: Fri, 19 Jun 2015 16:00:51 +0200	[thread overview]
Message-ID: <20150619140051.GA18930@gmail.com> (raw)
In-Reply-To: <55841ACF.50302@samsung.com>


* Andrey Ryabinin <a.ryabinin@samsung.com> wrote:

> On 06/19/2015 03:06 PM, Borislav Petkov wrote:
> > On Fri, Jun 19, 2015 at 02:49:19PM +0300, Andrey Ryabinin wrote:
> >> I guess that AMD cpus is more strict (unlike Intel) about violation
> >> of reserved/unused bits in page table entries. Please, try with this
> >> patch.
> > 
> > With that the guest boots.
> > 
> 
> Great! Thanks.
> 
> > How do I check whether KASan actually works? I don't see any note in
> > dmesg or some file named "*kasan*" in sysfs...
> > 
> 
> kasan will print report in dmesg whant it will find anything.

It should also printk a one line message at bootup, so that people can be sure 
they are running a KASan-enabled kernel.

> To make sure that it works you could try to load testing module (CONFIG_TEST_KASAN).
> This module has bugs that kasan should catch.

That's a way too obscure mechanism just to determine whether the right kernel 
config was booted. Please add a printk(), ok?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2015-06-19 14:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18  7:36 [PATCH v6 1/1] x86_64: fix KASan shadow region page tables Alexander Popov
2015-06-18  9:08 ` Borislav Petkov
2015-06-18 12:22   ` Andrey Ryabinin
2015-06-18 14:55     ` Borislav Petkov
2015-06-18 16:05       ` Andrey Ryabinin
2015-06-18 16:38         ` Borislav Petkov
2015-06-19 11:49           ` Andrey Ryabinin
2015-06-19 12:06             ` Borislav Petkov
2015-06-19 13:36               ` Andrey Ryabinin
2015-06-19 14:00                 ` Ingo Molnar [this message]
2015-06-19 14:06                   ` Borislav Petkov
2015-06-19 14:16                   ` Andrey Ryabinin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150619140051.GA18930@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.ryabinin@samsung.com \
    --cc=adech.fo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alpopov@ptsecurity.com \
    --cc=bp@alien8.de \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=kuleshovmail@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox