From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753653AbbFSOpk (ORCPT ); Fri, 19 Jun 2015 10:45:40 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43136 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbbFSOpc (ORCPT ); Fri, 19 Jun 2015 10:45:32 -0400 Date: Fri, 19 Jun 2015 17:45:14 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Joe Perches , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/9] staging: sm7xxfb: fix alignment Message-ID: <20150619144514.GS28762@mwanda> References: <1434540288-8289-1-git-send-email-sudipm.mukherjee@gmail.com> <1434540288-8289-6-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434540288-8289-6-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2015 at 04:54:44PM +0530, Sudip Mukherjee wrote: > @@ -346,9 +346,8 @@ static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, size_t > dst = buffer; > for (i = c >> 2; i--;) { > *dst = fb_readl(src++); > - *dst = > - (*dst & 0xff00ff00 >> 8) | > - (*dst & 0x00ff00ff << 8); > + *dst = (*dst & 0xff00ff00 >> 8) | > + (*dst & 0x00ff00ff << 8); This is supposed to convert __le16 to __be16? > dst++; > } > if (c & 3) { regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/