Re: [PATCH] serial: 8250: Do XR17V35X specific wakeup in serial8250_do_startup

Joerg Roedel
2015-07-28T07:21:04Z

Hi Peter,

On Fri, Jul 17, 2015 at 09:34:31AM -0400, Peter Hurley wrote:
> On 07/16/2015 04:29 AM, Joerg Roedel wrote:
> > From: Joerg Roedel <jroedel@suse.de>
> >
> > The XR17V35X UART needs the ECB bit set in its XR_EFR
> > register to enable access to IER [7:5], ISR [5:4], FCR[5:4],
> > MCR[7:5], and MSR [7:0].
> >
> > Also reset the IER register to mask interrupts after access
> > to all bits of this register has been enabled.
> >
> > This makes my 8-port XR17V35X working with the in-kernel
> > serial driver.
>
> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

Thanks for your review.

> Also, would you please find out what bits are set in the IER
> that this fixes and let me know? I don't have this hardware.

Unfortunatly I put the card back into a production machine and can't
easily check this anymore. But I'll let you know when I update the
kernel on the box next time.

Joerg