From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754292AbbFSXFw (ORCPT ); Fri, 19 Jun 2015 19:05:52 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:36759 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752667AbbFSXFq (ORCPT ); Fri, 19 Jun 2015 19:05:46 -0400 Date: Sat, 20 Jun 2015 01:05:40 +0200 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Adrian Hunter , Borislav Petkov , David Ahern , Don Zickus , Frederic Weisbecker , He Kuang , Jiri Olsa , Li Zhang , Masami Hiramatsu , Namhyung Kim , Naohiro Aota , Peter Zijlstra , pi3orama@163.com, Stephane Eranian , Sukadev Bhattiprolu , Wang Nan , Zefan Li Subject: Re: [RFC] hotkey for disabling/enabling events in 'perf top' TUI was Re: [GIT PULL 0/8] perf/core improvements and fixes Message-ID: <20150619230540.GA8876@gmail.com> References: <1434576155-30038-1-git-send-email-acme@kernel.org> <20150618074010.GA3194@gmail.com> <20150618201829.GF3079@kernel.org> <20150618205813.GA476@gmail.com> <20150618213949.GH3079@kernel.org> <20150619062711.GB9668@gmail.com> <20150619200738.GF31188@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150619200738.GF31188@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 19, 2015 at 08:27:11AM +0200, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo wrote: > > > Em Thu, Jun 18, 2015 at 10:58:13PM +0200, Ingo Molnar escreveu: > > > > * Arnaldo Carvalho de Melo wrote: > > > > > z Toggle zeroing of samples > > > > > / Filter symbol by name > > > > > Is 'f' (for 'freeze') still available? > > > > It is available in both the 'report'/'top' (aka the "hists" browser) and in the > > > annotate browser, so I'll go with it, and leave CTRL+z alone, then make it it > > > suspend. > > > Sounds good to me! > > I'm fixing these issues now and a mildly crazy idea ocurred to me: now we can go > from 'top' to 'report' and back, but only if we start in 'perf top', but I think > we could go from 'perf report' to 'perf top' mode too, i.e. start with a > perf.data file, then enable collecting more samples that would then be added to > the existing histograms, etc. > > Unsure if this would be useful tho ;-) Its just that it may be easy to do and > would be another step into having it all integrated. So I think the following would be useful for perf report: if we recorded the precise command line used, in the perf.data. So if someone types: perf record -e cache-misses make -j16 kernel then we'd have the whole command line in the perf.data: "perf record -e cache-misses make -j16 kernel" and if there was a hotkey to take new samples, using the exact same workload. This is non-trivial though. Going from 'perf report' to 'perf top' would be intuitive if the 'perf record' before was 'perf top' alike, for example: perf record -a sleep 10 or: perf record -a in that case going to 'perf top' is a natural extension of the profiling session. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/