From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Isaac Assegai <isaac.a.travers@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, gregkh@linuxfoundation.org,
teddy.wang@siliconmotion.com
Subject: Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines
Date: Sat, 20 Jun 2015 12:54:02 +0530 [thread overview]
Message-ID: <20150620072402.GA15195@sudip-PC> (raw)
In-Reply-To: <1434743301-14774-7-git-send-email-isaac.a.travers@gmail.com>
On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote:
> Place braces on previous lines in ddk750_sii164.c to
> rectify the following checkpatch errors:
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++-----------
> 1 file changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index 7f58fbe..64d4291 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -136,8 +136,7 @@ long sii164InitChip(
> #endif
>
> /* Check if SII164 Chip exists */
> - if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID))
> - {
> + if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID) {
^^^^
you have not build tested it :(
In function ‘sii164InitChip’:
error: expected ‘)’ before ‘{’ token
regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next parent reply other threads:[~2015-06-20 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1434743301-14774-1-git-send-email-isaac.a.travers@gmail.com>
[not found] ` <1434743301-14774-7-git-send-email-isaac.a.travers@gmail.com>
2015-06-20 7:24 ` Sudip Mukherjee [this message]
2015-06-23 8:55 ` [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines Dan Carpenter
2015-06-23 9:53 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150620072402.GA15195@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=isaac.a.travers@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox