From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753586AbbFTHYU (ORCPT ); Sat, 20 Jun 2015 03:24:20 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:35097 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbbFTHYN (ORCPT ); Sat, 20 Jun 2015 03:24:13 -0400 Date: Sat, 20 Jun 2015 12:54:02 +0530 From: Sudip Mukherjee To: Isaac Assegai Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, gregkh@linuxfoundation.org, teddy.wang@siliconmotion.com Subject: Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines Message-ID: <20150620072402.GA15195@sudip-PC> References: <1434743301-14774-1-git-send-email-isaac.a.travers@gmail.com> <1434743301-14774-7-git-send-email-isaac.a.travers@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1434743301-14774-7-git-send-email-isaac.a.travers@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > Place braces on previous lines in ddk750_sii164.c to > rectify the following checkpatch errors: > ERROR: that open brace { should be on the previous line > > Signed-off-by: Isaac Assegai > --- > drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > index 7f58fbe..64d4291 100644 > --- a/drivers/staging/sm750fb/ddk750_sii164.c > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > @@ -136,8 +136,7 @@ long sii164InitChip( > #endif > > /* Check if SII164 Chip exists */ > - if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID)) > - { > + if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID) { ^^^^ you have not build tested it :( In function ‘sii164InitChip’: error: expected ‘)’ before ‘{’ token regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/