From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932368AbbFTOsT (ORCPT ); Sat, 20 Jun 2015 10:48:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59666 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754547AbbFTOsM (ORCPT ); Sat, 20 Jun 2015 10:48:12 -0400 Date: Sat, 20 Jun 2015 07:48:11 -0700 From: Greg KH To: Geliang Tang Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: fix sparse warning in ni_mio_common.c Message-ID: <20150620144811.GA28120@kroah.com> References: <1434818854-19017-1-git-send-email-geliangtang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434818854-19017-1-git-send-email-geliangtang@163.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 20, 2015 at 04:47:33PM +0000, Geliang Tang wrote: > This patch fixes the following sparse warning: > > drivers/staging/comedi/drivers/ni_mio_common.c:573:26: warning: shift > too big (4294967295) for type int > > Signed-off-by: Geliang Tang > --- > drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c > index 6cc304a..420f752 100644 > --- a/drivers/staging/comedi/drivers/ni_mio_common.c > +++ b/drivers/staging/comedi/drivers/ni_mio_common.c > @@ -570,7 +570,7 @@ static inline void ni_set_bitfield(struct comedi_device *dev, int reg, > static inline unsigned ni_stc_dma_channel_select_bitfield(unsigned channel) > { > if (channel < 4) > - return 1 << channel; > + return 1 << (channel & 0x03); Look at the code, this change makes no sense. Sometimes tools are wrong, use them as a hint, not as something that has to be silenced. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/