Re: [RFC v2 3/3] mm: make swapin readahead to improve thp collapse rate

Kirill A. Shutemov
2015-06-21T19:20:47Z

On Sun, Jun 21, 2015 at 09:11:31PM +0300, Kirill A. Shutemov wrote:
> On Sat, Jun 20, 2015 at 02:28:06PM +0300, Ebru Akagunduz wrote:
> > + /* pte is unmapped now, we need to map it */
> > + pte = pte_offset_map(pmd, _address);
>
> No, it's within the same pte page table. It should be mapped with
> pte_offset_map() above.

Ahh.. do_swap_page() will unmap it. Probably worth rewording the comment.

--
Kirill A. Shutemov